merlimat commented on code in PR #25304:
URL: https://github.com/apache/pulsar/pull/25304#discussion_r2921315444
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java:
##########
@@ -179,11 +177,8 @@ public void updateTenant(@Suspended final AsyncResponse
asyncResponse,
if (!tenantAdmin.isPresent()) {
throw new RestException(Status.NOT_FOUND, "Tenant " +
tenant + " not found");
}
- TenantInfo oldTenantAdmin = tenantAdmin.get();
- Set<String> newClusters = new
HashSet<>(newTenantAdmin.getAllowedClusters());
- return canUpdateCluster(tenant,
oldTenantAdmin.getAllowedClusters(), newClusters);
+ return tenantResources().updateTenantAsync(tenant, old ->
newTenantAdmin);
Review Comment:
That's a good catch. I think the check was broken as in that it only really
worked for v1 namespaces...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
