shibd commented on code in PR #25304:
URL: https://github.com/apache/pulsar/pull/25304#discussion_r2923498595
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/NamespacesImpl.java:
##########
@@ -90,7 +88,7 @@ public List<String> getNamespaces(String tenant, String
cluster) throws PulsarAd
}
public CompletableFuture<List<String>> getNamespacesAsync(String tenant,
String cluster) {
Review Comment:
Do we need to remove this method?
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/NamespacesImpl.java:
##########
@@ -90,7 +88,7 @@ public List<String> getNamespaces(String tenant, String
cluster) throws PulsarAd
}
public CompletableFuture<List<String>> getNamespacesAsync(String tenant,
String cluster) {
- WebTarget path = adminNamespaces.path(tenant).path(cluster);
+ WebTarget path = adminV2Namespaces.path(tenant).path(cluster);
Review Comment:
This deprecated admin API method is still present, but it now calls
`/admin/v2/namespaces/{tenant}/{cluster}`. I do not see a matching broker
endpoint for that path, so it looks like this will now 404 or hit the wrong V2
route. If the intent is to remove `getNamespaces(tenant, cluster)`, could we
drop it from the public admin API too? Otherwise it probably needs a compatible
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
