codelipenghui commented on code in PR #25304:
URL: https://github.com/apache/pulsar/pull/25304#discussion_r2920544528
##########
pulsar-common/src/main/java/org/apache/pulsar/common/naming/NamespaceName.java:
##########
@@ -128,17 +115,12 @@ public String getTenant() {
return tenant;
}
- @Deprecated
- public String getCluster() {
- return cluster;
- }
-
public String getLocalName() {
return localName;
}
Review Comment:
**Note:** `isGlobal()` now always returns `true`. This is logically correct
for V2, but callers like
`PulsarWebResource.checkLocalOrGetPeerReplicationCluster()` previously skipped
non-global namespaces. Now ALL namespaces trigger peer-replication metadata
lookups, which adds overhead for single-cluster deployments.
Also, dead `\!isGlobal()` checks remain in files not touched by this PR:
- `PersistentTopicsBase.java` (lines ~4967, ~5107)
- `NonPersistentTopic.java` (line ~586)
- `PersistentTopic.java` (line ~1945)
These should be cleaned up to avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
