Technoboy- commented on code in PR #24390:
URL: https://github.com/apache/pulsar/pull/24390#discussion_r2244358573
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java:
##########
@@ -177,11 +189,11 @@ public CompletableFuture<Void>
updateTopicPoliciesAsync(TopicName topicName, Top
return CompletableFuture.failedFuture(new
BrokerServiceException.NotAllowedException(
"Not allowed to update topic policy for the heartbeat
topic"));
}
- return sendTopicPolicyEvent(topicName, ActionType.UPDATE, policies);
+ return sendTopicPolicyEvent(topicName, ActionType.UPDATE, policies,
false);
}
private CompletableFuture<Void> sendTopicPolicyEvent(TopicName topicName,
ActionType actionType,
- @Nullable
TopicPolicies policies) {
+ @Nullable TopicPolicies policies, boolean
keepGlobalPoliciesAfterDeleting) {
Review Comment:
`keepGlobalPoliciesAfterDeleting` -> `keepGlobalPolicies`
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java:
##########
@@ -223,14 +236,20 @@ private CompletableFuture<Void>
sendTopicPolicyEvent(TopicName topicName, Action
}
private CompletableFuture<MessageId>
sendTopicPolicyEventInternal(TopicName topicName, ActionType actionType,
- SystemTopicClient.Writer<PulsarEvent>
writer,
- @Nullable TopicPolicies policies) {
+ SystemTopicClient.Writer<PulsarEvent> writer, @Nullable
TopicPolicies policies,
+ boolean keepGlobalPoliciesAfterDeleting) {
Review Comment:
`keepGlobalPoliciesAfterDeleting` -> `keepGlobalPolicies`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
