Technoboy- commented on code in PR #24390:
URL: https://github.com/apache/pulsar/pull/24390#discussion_r2239793913
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java:
##########
@@ -139,6 +139,17 @@ public SystemTopicBasedTopicPoliciesService(PulsarService
pulsarService) {
@Override
public CompletableFuture<Void> deleteTopicPoliciesAsync(TopicName
topicName) {
+ return deleteTopicPoliciesAsync(topicName, false);
+ }
+
+ /**
+ * @param keepGlobalPoliciesAfterDeleting only be used when a topic was
deleted because users removes current
+ * cluster from the policy "replicatedClusters".
+ * See also https://github.com/apache/pulsar/blob/master/pip/pip-422.md
+ */
+ @Override
+ public CompletableFuture<Void> deleteTopicPoliciesAsync(TopicName
topicName,
+ boolean
keepGlobalPoliciesAfterDeleting) {
Review Comment:
`keepGlobalPoliciesAfterDeleting` -> `keepGlobalPolicies`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
