Technoboy- commented on code in PR #24390:
URL: https://github.com/apache/pulsar/pull/24390#discussion_r2239916109
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicPoliciesService.java:
##########
@@ -47,6 +51,16 @@ public interface TopicPoliciesService extends AutoCloseable {
*/
CompletableFuture<Void> deleteTopicPoliciesAsync(TopicName topicName);
+ default CompletableFuture<Void> deleteTopicPoliciesAsync(TopicName
topicName,
+ boolean
keepGlobalPoliciesAfterDeleting) {
+ if (keepGlobalPoliciesAfterDeleting) {
+ LOG.warn("The current implementation of TopicPoliciesService has
not implemented the method"
+ + " deleteTopicPoliciesAsync(TopicName, boolean) yet, please
implement it, see also"
+ + "
https://github.com/apache/pulsar/blob/master/pip/pip-422.md";);
Review Comment:
This seems not good to print this here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
