BewareMyPower commented on code in PR #24522:
URL: https://github.com/apache/pulsar/pull/24522#discussion_r2212016862
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java:
##########
@@ -420,6 +420,13 @@ void asyncOpenCursor(String name, InitialPosition
initialPosition, Map<String, L
*/
long getOffloadedSize();
+ /**
+ * Reset Exception before write to null.
+ */
+ default void resetExceptionBeforeWrite() {
Review Comment:
Anyway, the document of this method is very ambiguous.
Assuming I'm going to use managed ledger directly in the downstream rather
than using the `PersistentTopic`, when should I call
`resetExceptionBeforeWrite`? The comment only describes what this method does,
but it does not describe when should it be called and the side effect after
it's called.
I agree it should be done within the `managed-ledger` module. Is it possible
to move it to the interceptor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
