dao-jun commented on code in PR #24522:
URL: https://github.com/apache/pulsar/pull/24522#discussion_r2210846004


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java:
##########
@@ -420,6 +420,13 @@ void asyncOpenCursor(String name, InitialPosition 
initialPosition, Map<String, L
      */
     long getOffloadedSize();
 
+    /**
+     * Reset Exception before write to null.
+     */
+    default void resetExceptionBeforeWrite() {

Review Comment:
   I understand add `resetExceptionBeforeWrite` maybe could lead to confusion, 
but `ManagedLedgerImpl.state` is very complex, and it's the core of pulsar, 
making hasty modifications may lead to serious problems.
   The current impl is the easiest way to solve the issue, I think. Compromised 
towards complexity.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to