BewareMyPower commented on code in PR #24522:
URL: https://github.com/apache/pulsar/pull/24522#discussion_r2210114915
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java:
##########
@@ -420,6 +420,13 @@ void asyncOpenCursor(String name, InitialPosition
initialPosition, Map<String, L
*/
long getOffloadedSize();
+ /**
+ * Reset Exception before write to null.
+ */
+ default void resetExceptionBeforeWrite() {
Review Comment:
I see the 1st solution is not available because when the topic is fenced,
there have been `OpAddEntry` objects queued in the managed ledger.
<img width="1648" height="386" alt="image"
src="https://github.com/user-attachments/assets/21ae4293-a4e4-4982-8280-f8e33104d3f3";
/>
I think introducing fence mechanism to ML might work
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java:
##########
@@ -420,6 +420,13 @@ void asyncOpenCursor(String name, InitialPosition
initialPosition, Map<String, L
*/
long getOffloadedSize();
+ /**
+ * Reset Exception before write to null.
+ */
+ default void resetExceptionBeforeWrite() {
Review Comment:
I see the 1st solution is not possible because when the topic is fenced,
there have been `OpAddEntry` objects queued in the managed ledger.
<img width="1648" height="386" alt="image"
src="https://github.com/user-attachments/assets/21ae4293-a4e4-4982-8280-f8e33104d3f3";
/>
I think introducing fence mechanism to ML might work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
