andvasp commented on PR #2674:
URL: https://github.com/apache/plc4x/pull/2674#issuecomment-5280161892
Hi @chrisdutz.
Reading through the code, I understand that we use Get_Attribute_All to
check if the PLC supports the Connection Manager (CM) and Message Router (MR).
However, while investigating an issue, I noticed that when we use
Get_Attribute_All, we must specify which class attributes we are requesting.
Currently, the code is only searching for attributes of the MR (using the value
2 in the snippet below). Because of this, when I received a ServiceNotSupported
status, it actually meant the MR was not supported, rather than the entire
connection probe failing.
```java
private CompletableFuture<Void> probeAttributes() {
PathSegment classSegment = new LogicalSegment(new ClassID((byte) 0,
(short) 2));
```
Which class has its attributes, for example:
Identity (Vendor ID, Device Type, Product Code,..)
Connection Manager (Revision, Max Instance, Number of Instances)
If you agree, I will submit a modification accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
