andvasp commented on code in PR #2674:
URL: https://github.com/apache/plc4x/pull/2674#discussion_r3757021953
##########
protocols/eip/src/main/resources/protocols/eip/eip.mspec:
##########
@@ -157,10 +157,17 @@
[array byte servicesData count 'serviceLen - 6 - (2 *
serviceNb)' ]
]
['0x0E','false' GetAttributeSingleRequest
- // TODO: Implement
+ [implicit uint 8 requestPathSize
'(classSegment.lengthInBytes + instanceSegment.lengthInBytes +
attributeSegment.lengthInBytes)/2']
+ [simple PathSegment classSegment
]
+ [simple PathSegment instanceSegment
]
+ [simple PathSegment attributeSegment
]
]
['0x0E','true' GetAttributeSingleResponse
- // TODO: Implement
+ [reserved uint 8 '0x00'
]
+ [simple uint 8 status
]
+ [simple uint 8 extStatusSize
]
+ [array uint 8 extStatus count 'extStatusSize'
]
+ [array byte servicesData count 'serviceLen - 4 -
extStatusSize' ]
Review Comment:
Yes. Now I'm curious.
The "header" message specification layout is the same in both messages
(Reply Service, Reserved, Status, Additional Status Size, and Additional
Status).
I don't know much about *mspec*, but it looks to me like the `extStatusSize`
field is missing from `GetAttributeAllResponse`. Am I doing something wrong
with `GetAttributeSingleResponse`? Why is there this difference?
@chrisdutz, could you clarify this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
