andvasp commented on PR #2674:
URL: https://github.com/apache/plc4x/pull/2674#issuecomment-5255391021
> ## Pull request overview
> Copilot reviewed 3 out of 7 changed files in this pull request and
generated no new comments.
>
> Suppressed comments (3)
> **protocols/eip/src/main/resources/protocols/eip/eip.mspec:170**
>
> * `extStatusSize` is the number of 16-bit additional-status words, but
this models each entry as 8 bits and subtracts only one byte per entry. Any
response with a nonzero additional status will therefore split the status word
and expose its second byte as `servicesData`; serialization also emits an
invalid packet. Define `extStatus` as `uint 16`, subtract `2 * extStatusSize`,
regenerate the generated models, and cover a nonzero additional-status response.
>
> ```
> [array uint 8 extStatus count
'extStatusSize' ]
> [array byte servicesData count 'serviceLen - 4 -
extStatusSize' ]
> ```
Would be just necessary change uint 8 to 16 like below?
```
[array uint 16 extStatus count
'extStatusSize' ]
[array byte servicesData count 'serviceLen - 4 -
extStatusSize' ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
