ege-st commented on PR #12613: URL: https://github.com/apache/pinot/pull/12613#issuecomment-1991939033
That's a very good suggestion, I'll do that. On Tue, Mar 12, 2024, 8:14 AM Gonzalo Ortiz Jaureguizar < ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java > <https://github.com/apache/pinot/pull/12613#discussion_r1521654351>: > > > @@ -141,27 +141,6 @@ public void testCaseWhenStatements() { > Assert.assertEquals(caseFunc.getOperands().get(6).getLiteral().getFieldValue(), 0L); > } > > - @Test(expectedExceptions = SqlCompilationException.class) > - public void testInvalidCaseWhenStatements() { > > Couldn't we reuse the text to verify this works now? > > Even something as simple as compiling the same SQL query and assert no > failure is found. May not be super useful, but given it is already written, > we could use it > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/pinot/pull/12613#pullrequestreview-1931371326>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BAASDJ2EDIFY2GIXBPXMNDLYX4LVNAVCNFSM6AAAAABEO7KSI6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMZRGM3TCMZSGY> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
