gortiz commented on code in PR #12613:
URL: https://github.com/apache/pinot/pull/12613#discussion_r1521654351
##########
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java:
##########
@@ -141,27 +141,6 @@ public void testCaseWhenStatements() {
Assert.assertEquals(caseFunc.getOperands().get(6).getLiteral().getFieldValue(),
0L);
}
- @Test(expectedExceptions = SqlCompilationException.class)
- public void testInvalidCaseWhenStatements() {
Review Comment:
Couldn't we reuse the text to verify this works now?
Even something as simple as compiling the same SQL query and assert no
failure is found. May not be super useful, but given it is already written, we
could use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
