ege-st commented on PR #12613: URL: https://github.com/apache/pinot/pull/12613#issuecomment-1989677453
Correct. I added a test for v2 because I didn't see one and just wanted to be thorough. Hiwever I had a comment that I couldn't find the right place to add the test for V1. So just need to find out where to write that test and I'll add it. On Mon, Mar 11, 2024, 5:05 PM Xiaotian (Jackie) Jiang < ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > pinot-query-runtime/src/test/java/org/apache/pinot/query/QueryTestSet.java > <https://github.com/apache/pinot/pull/12613#discussion_r1520582092>: > > > + new Object[]{"SELECT a.col1, CASE WHEN sum(a.col3) = 0 THEN 0 ELSE SUM(a.col3) END AS match_sum " > + + " FROM a WHERE a.ts >= 1600000000 GROUP BY a.col1"}, > > Actually we want to add tests for V1. It is already working in V2 > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/pinot/pull/12613#discussion_r1520582092>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/BAASDJYTOC73P7DVTEJSLV3YXZIF3AVCNFSM6AAAAABEO7KSI6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRZHA3DENRTGY> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
