somandal commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2138291939
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java:
##########
@@ -32,9 +32,9 @@ public class RebalanceConfig {
public static final long DEFAULT_EXTERNAL_VIEW_CHECK_INTERVAL_IN_MS = 1000L;
// 1 second
public static final long DEFAULT_EXTERNAL_VIEW_STABILIZATION_TIMEOUT_IN_MS =
3600000L; // 1 hour
- // Whether to rebalance table in dry-run mode
+ // Whether to rebalance table in dry-run mode.
@JsonProperty("dryRun")
- @ApiModelProperty(example = "false")
+ @ApiModelProperty(example = "true")
Review Comment:
shouldn't be a big deal either way though, people should be modifying that -
and in the future we plan to have a UI to address this so unless someone really
needs to use swagger due to some missing parameter or something, don't see why
they'd need this. okay with this change, but do consider this UI aspect,
especially when designing to minimize the need to use swagger
probably not possible, but is there a way to make `dryRun` and `preChecks` a
query option instead, but only for tenant rebalance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
