J-HowHuang commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2136687663
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/tenant/TenantRebalanceConfig.java:
##########
@@ -27,18 +27,32 @@
public class TenantRebalanceConfig extends RebalanceConfig {
+ // These fields are parameters for tenant rebalance. Hiding them in the
swagger UI because we expect them to be set
+ // via query parameters. User can still set the fields in the POST body
without errors, but it will be overridden by
+ // the values specified via query parameters.
@JsonIgnore
+ @ApiModelProperty(hidden = true)
private String _tenantName;
@JsonProperty("degreeOfParallelism")
- @ApiModelProperty(example = "1")
+ @ApiModelProperty(hidden = true)
Review Comment:
Yes. Setting in only either place makes it still appear in the Swagger UI,
which is a weird behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
