somandal commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2124115039
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/tenant/TenantRebalanceConfig.java:
##########
@@ -63,6 +79,7 @@ public void setParallelWhitelist(Set<String>
parallelWhitelist) {
_parallelWhitelist = parallelWhitelist;
}
+ @ApiModelProperty(hidden = true)
Review Comment:
Can you find out the correct process to make backward incompatible changes
to API and functionality? Have we done any analysis on whether anyone in OSS is
using this? Should we come up with a version 2 of the API and leave this one as
is and mark it as deprecated (but keep the functionality the same and working
the same way)?
perhaps reach out to @Jackie-Jiang or someone more familiar with how to
handle backward incompatibility for some ideas. It’s okay to remove this
completely if we can find out no one is using this, otherwise there might be
complaints from OSS community
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
