vrajat commented on code in PR #16004:
URL: https://github.com/apache/pinot/pull/16004#discussion_r2136894900
##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -310,22 +325,26 @@ public void
setThreadResourceUsageProvider(ThreadResourceUsageProvider threadRes
}
@Override
- public void createExecutionContextInner(@Nullable String queryId, int
taskId,
- ThreadExecutionContext.TaskType taskType, @Nullable
ThreadExecutionContext parentContext) {
+ public void setupRunner(@Nullable String queryId, int taskId,
ThreadExecutionContext.TaskType taskType) {
Review Comment:
The major work is that query id is generated in the broker. These queries
are submitted to the server directly. I've created an issue for it #16059 .
Regardless, its a good idea to safeguard this code ? Query id can be null
because code is not instrumented, other query engines etc.
`parentContext == null` is a standard concern in MSE & SSE because
instrumentation is missed. In those cases, a worker will be considered a runner
rather bailing out on capturing wrong metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
