vvivekiyer commented on code in PR #16004:
URL: https://github.com/apache/pinot/pull/16004#discussion_r2136151788
##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -310,22 +325,26 @@ public void
setThreadResourceUsageProvider(ThreadResourceUsageProvider threadRes
}
@Override
- public void createExecutionContextInner(@Nullable String queryId, int
taskId,
- ThreadExecutionContext.TaskType taskType, @Nullable
ThreadExecutionContext parentContext) {
+ public void setupRunner(@Nullable String queryId, int taskId,
ThreadExecutionContext.TaskType taskType) {
Review Comment:
I understand the reasoning that GRPC queries will not have queryId. I would
rather pass the queryId there than fix this functions to take null queryId.
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Tracing.java:
##########
@@ -172,22 +171,23 @@ public InvocationRecording activeRecording() {
*/
public static class DefaultThreadResourceUsageAccountant implements
ThreadResourceUsageAccountant {
Review Comment:
Can we just totally remove DefaultThreadResourceUsageAccountant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
