Copilot commented on code in PR #16004:
URL: https://github.com/apache/pinot/pull/16004#discussion_r2127963436
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Tracing.java:
##########
@@ -185,6 +184,16 @@ public boolean isAnchorThreadInterrupted() {
return thread != null && thread.isInterrupted();
}
+ @Override
+ public void createExecutionContext(String queryId, int taskId,
ThreadExecutionContext.TaskType taskType,
+ @Nullable ThreadExecutionContext parentContext) {
+ }
+
Review Comment:
[nitpick] Empty no-op stubs for `createExecutionContext` and
`createExecutionContextInner` can be confusing; consider removing these methods
or marking them @Deprecated with explanatory comments if they must remain.
```suggestion
@Override
/**
* @deprecated This method is a no-op and is not recommended for use. It
is retained for backward compatibility.
* Future implementations should provide meaningful
functionality or remove this method entirely.
*/
@Deprecated
public void createExecutionContext(String queryId, int taskId,
ThreadExecutionContext.TaskType taskType,
@Nullable ThreadExecutionContext parentContext) {
}
/**
* @deprecated This method is a no-op and is not recommended for use. It
is retained for backward compatibility.
* Future implementations should provide meaningful
functionality or remove this method entirely.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
