xiaoxiang781216 commented on code in PR #1654:
URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1144531747
##########
nshlib/nsh_parse.c:
##########
@@ -115,6 +129,14 @@ struct nsh_memlist_s
};
#endif
+#ifdef CONFIG_NSH_ALIAS
+struct nsh_alist_s
+{
+ int nallocs;
+ FAR struct nsh_alias_s *allocs[CONFIG_NSH_ALIAS_MAX_AMOUNT];
Review Comment:
If so, look like it's better to manage the expansion list directly:
https://github.com/apache/nuttx-apps/pull/1654/files#diff-7ba973a1f25993d049f08f4b5d54ac41f9a0955f4f2642c0ddb069dde7c4c5e4R124-R130
for example, adding an expansion and move the alias from alist to expansion
list vice vesa.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
