xiaoxiang781216 commented on code in PR #1654:
URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1144213978
##########
nshlib/nsh_parse.c:
##########
@@ -115,6 +129,14 @@ struct nsh_memlist_s
};
#endif
+#ifdef CONFIG_NSH_ALIAS
+struct nsh_alist_s
+{
+ int nallocs;
+ FAR struct nsh_alias_s *allocs[CONFIG_NSH_ALIAS_MAX_AMOUNT];
Review Comment:
why need another table to keep the expanded variable if nsh_alias_s already
has exp field? It's more simple to iterate all alias and clear exp directly
after the end of expansion. With this approach, we can remove rem field and
simplify the free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
