xiaoxiang781216 commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1144206136
########## nshlib/nsh_console.h: ########## @@ -153,6 +155,15 @@ struct console_stdio_s size_t varsz; #endif +#ifdef CONFIG_NSH_ALIAS Review Comment: you can think nsh_vtbl_s is a base class and console_stdio_s is a derived class(handle the different I/O), more derived classes may add later. So if this is a common feature for all derived class, nsh_vtbl_s is a better place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
