pkarashchenko commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r991247553
##########
drivers/audio/vs1053.c:
##########
@@ -1210,7 +1210,7 @@ static void vs1053_feeddata(FAR struct vs1053_struct_s
*dev)
/* Pop the next entry */
- apb = (struct ap_buffer_s *) dq_remfirst(&dev->apbq);
+ apb = (struct ap_buffer_s *)dq_remfirst(&dev->apbq);
Review Comment:
```suggestion
apb = (FAR struct ap_buffer_s *)dq_remfirst(&dev->apbq);
```
##########
drivers/audio/vs1053.c:
##########
@@ -1280,7 +1280,7 @@ static int vs1053_dreq_isr(int irq, FAR void *context,
FAR void *arg)
static void *vs1053_workerthread(pthread_addr_t pvarg)
Review Comment:
```suggestion
static FAR void *vs1053_workerthread(pthread_addr_t pvarg)
```
##########
drivers/audio/vs1053.c:
##########
@@ -1249,7 +1249,7 @@ static void vs1053_feeddata(FAR struct vs1053_struct_s
*dev)
static int vs1053_dreq_isr(int irq, FAR void *context, FAR void *arg)
{
- struct vs1053_struct_s *dev = (struct vs1053_struct_s *)arg;
+ struct vs1053_struct_s *dev = (FAR struct vs1053_struct_s *)arg;
Review Comment:
```suggestion
FAR struct vs1053_struct_s *dev = (FAR struct vs1053_struct_s *)arg;
```
##########
drivers/modem/altair/altmdm_spi.c:
##########
@@ -382,7 +382,7 @@ static void init_rxbuffer(FAR struct altmdm_dev_s *priv,
{
memset(l_buff, 0x00, sizeof(struct altmdm_spi_rxbuff_s));
- l_buff->buff_addr = (char *)kmm_malloc(unit_size);
+ l_buff->buff_addr = (FAr char *)kmm_malloc(unit_size);
Review Comment:
```suggestion
l_buff->buff_addr = (FAR char *)kmm_malloc(unit_size);
```
##########
drivers/lcd/st7032.c:
##########
@@ -67,7 +68,7 @@ struct st7032_dev_s
uint8_t col; /* Current col position to write on display */
uint8_t buffer[ST7032_MAX_ROW * ST7032_MAX_COL];
bool pendscroll;
- sem_t sem_excl;
+ mutex_t lock;
Review Comment:
```suggestion
mutex_t lock;
```
##########
drivers/modem/altair/altmdm_pm.c:
##########
@@ -54,7 +54,7 @@
****************************************************************************/
static struct altmdm_dev_s *g_privdata = NULL;
Review Comment:
```suggestion
static FAR struct altmdm_dev_s *g_privdata = NULL;
```
##########
drivers/lcd/st7032.c:
##########
@@ -146,11 +147,11 @@ static inline void st7032_write_inst(FAR struct
st7032_dev_s *priv,
/* Setup the ST7032 Co command */
- msg.frequency = CONFIG_ST7032_I2C_FREQ; /* I2C frequency */
- msg.addr = ST7032_I2C_ADDR; /* 7-bit address */
- msg.flags = 0; /* Write transaction, beginning
with START */
- msg.buffer = (FAR uint8_t *) data; /* Transfer from this address */
- msg.length = 2; /* Send two bytes */
+ msg.frequency = CONFIG_ST7032_I2C_FREQ; /* I2C frequency */
+ msg.addr = ST7032_I2C_ADDR; /* 7-bit address */
+ msg.flags = 0; /* Write transaction, beginning with
START */
+ msg.buffer =data; /* Transfer from this address */
Review Comment:
```suggestion
msg.buffer = data; /* Transfer from this address */
```
##########
drivers/clk/clk.h:
##########
@@ -50,12 +50,12 @@
static inline void clk_write(uint32_t reg, uint32_t value)
{
- *((volatile uint32_t *) (reg)) = value;
+ *((volatile uint32_t *)(reg)) = value;
}
static inline uint32_t clk_read(uint32_t reg)
{
- return *((volatile uint32_t *) (reg));
+ return *((volatile uint32_t *)(reg));
Review Comment:
```suggestion
return *((FAR volatile uint32_t *)(reg));
```
##########
drivers/can/mcp2515.c:
##########
@@ -198,7 +199,7 @@ struct mcp2515_can_s
struct mcp2515_config_s *config; /* The constant configuration */
Review Comment:
```suggestion
FAR struct mcp2515_config_s *config; /* The constant configuration */
```
##########
drivers/clk/clk.h:
##########
@@ -50,12 +50,12 @@
static inline void clk_write(uint32_t reg, uint32_t value)
{
- *((volatile uint32_t *) (reg)) = value;
+ *((volatile uint32_t *)(reg)) = value;
Review Comment:
```suggestion
*((FAR volatile uint32_t *)(reg)) = value;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
