pkarashchenko commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989138805
##########
drivers/sensors/lps25h.c:
##########
@@ -708,31 +709,31 @@ static int lps25h_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
break;
case SNIOC_PRESSURE_OUT:
- ret = lps25h_read_pressure(dev, (lps25h_pressure_data_t *) arg);
+ ret = lps25h_read_pressure(dev, (lps25h_pressure_data_t *)arg);
break;
case SNIOC_TEMPERATURE_OUT:
/* NOTE: call SNIOC_PRESSURE_OUT before this one,
* or results are bogus.
*/
- ret = lps25h_read_temper(dev, (lps25h_temper_data_t *) arg);
+ ret = lps25h_read_temper(dev, (lps25h_temper_data_t *)arg);
Review Comment:
```suggestion
ret = lps25h_read_temper(dev, (FAR lps25h_temper_data_t *)arg);
```
##########
drivers/sensors/lps25h.c:
##########
@@ -708,31 +709,31 @@ static int lps25h_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
break;
case SNIOC_PRESSURE_OUT:
- ret = lps25h_read_pressure(dev, (lps25h_pressure_data_t *) arg);
+ ret = lps25h_read_pressure(dev, (lps25h_pressure_data_t *)arg);
break;
case SNIOC_TEMPERATURE_OUT:
/* NOTE: call SNIOC_PRESSURE_OUT before this one,
* or results are bogus.
*/
- ret = lps25h_read_temper(dev, (lps25h_temper_data_t *) arg);
+ ret = lps25h_read_temper(dev, (lps25h_temper_data_t *)arg);
break;
case SNIOC_SENSOR_OFF:
ret = lps25h_power_on_off(dev, false);
break;
case SNIOC_GET_DEV_ID:
- ret = lps25h_who_am_i(dev, (lps25h_who_am_i_data *) arg);
+ ret = lps25h_who_am_i(dev, (lps25h_who_am_i_data *)arg);
Review Comment:
```suggestion
ret = lps25h_who_am_i(dev, (FAR lps25h_who_am_i_data *)arg);
```
##########
drivers/sensors/lps25h.c:
##########
@@ -708,31 +709,31 @@ static int lps25h_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
break;
case SNIOC_PRESSURE_OUT:
- ret = lps25h_read_pressure(dev, (lps25h_pressure_data_t *) arg);
+ ret = lps25h_read_pressure(dev, (lps25h_pressure_data_t *)arg);
Review Comment:
```suggestion
ret = lps25h_read_pressure(dev, (FAR lps25h_pressure_data_t *)arg);
```
##########
drivers/sensors/apds9960.c:
##########
@@ -1029,7 +1029,7 @@ static int apds9960_readgesture(FAR struct apds9960_dev_s
*priv)
{
bytes_read = fifo_level * 4;
ret = apds9960_i2c_read(priv, APDS9960_GFIFO_U,
- (uint8_t *) fifo_data, bytes_read);
+ (uint8_t *)fifo_data, bytes_read);
Review Comment:
```suggestion
(FAR uint8_t *)fifo_data, bytes_read);
```
##########
drivers/sensors/mlx90393.c:
##########
@@ -499,9 +499,9 @@ static ssize_t mlx90393_read(FAR struct file *filep, FAR
char *buffer,
data->z_mag = priv->data.z_mag;
data->temperature = priv->data.temperature;
- /* Give back the semaphore */
+ /* Give back the mutex */
- nxsem_post(&priv->datasem);
+ nxmutex_unlock(&priv->datalock);
return sizeof(FAR struct mlx90393_sensor_data_s);
Review Comment:
```suggestion
return sizeof(struct mlx90393_sensor_data_s);
```
##########
drivers/sensors/lsm330_spi.c:
##########
@@ -1409,7 +1405,7 @@ int lsm330_register(FAR const char *devpath_acl,
priv->flink = g_lsm330g_list;
g_lsm330g_list = priv;
- config_gyro->leaf_handle = (void *) priv;
+ config_gyro->leaf_handle = (void *)priv;
Review Comment:
```suggestion
config_gyro->leaf_handle = (FAR void *)priv;
```
##########
drivers/sensors/lsm330_spi.c:
##########
@@ -1370,7 +1367,7 @@ int lsm330_register(FAR const char *devpath_acl,
priv->flink = g_lsm330a_list;
g_lsm330a_list = priv;
priva = priv;
- config_acl->leaf_handle = (void *) priv;
+ config_acl->leaf_handle = (void *)priv;
Review Comment:
```suggestion
config_acl->leaf_handle = (FAR void *)priv;
```
##########
drivers/sensors/mpu60x0.c:
##########
@@ -537,7 +537,7 @@ static inline int __mpu_write_reg(FAR struct mpu_dev_s *dev,
static inline int __mpu_read_imu(FAR struct mpu_dev_s *dev,
FAR struct sensor_data_s *buf)
{
- return __mpu_read_reg(dev, ACCEL_XOUT_H, (uint8_t *) buf, sizeof(*buf));
+ return __mpu_read_reg(dev, ACCEL_XOUT_H, (uint8_t *)buf, sizeof(*buf));
Review Comment:
```suggestion
return __mpu_read_reg(dev, ACCEL_XOUT_H, (FAR uint8_t *)buf, sizeof(*buf));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
