[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

[GitBox]

pkarashchenko commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989432412


##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_gspi_f2_frame.c:
##########
@@ -309,12 +309,12 @@ int bcmf_gspi_read_f2_frame(FAR struct bcmf_dev_s *priv,
 
 int bcmf_gspi_send_f2_frame(FAR struct bcmf_dev_s *priv)
 {
-  FAR bcmf_gspi_dev_t      *gbus = (FAR bcmf_gspi_dev_t *)priv->bus;
-  FAR gspi_dev_t           *gspi = gbus->gspi;
-  f2_frame_header_t       *header;
-  bcmf_interface_frame_t  *iframe;
-  int                      ret;
-  bool                     is_txframe;
+  FAR bcmf_gspi_dev_t    *gbus = (FAR bcmf_gspi_dev_t *)priv->bus;
+  FAR gspi_dev_t         *gspi = gbus->gspi;
+  f2_frame_header_t      *header;
+  bcmf_interface_frame_t *iframe;

Review Comment:
   ```suggestion
     FAR bcmf_interface_frame_t *iframe;
   ```



##########
drivers/wireless/lpwan/sx127x/sx127x.c:
##########
@@ -502,7 +503,7 @@ static inline void sx127x_select(struct sx127x_dev_s * dev)
  * Name: sx127x_deselect
  ****************************************************************************/
 
-static inline void sx127x_deselect(struct sx127x_dev_s * dev)
+static inline void sx127x_deselect(struct sx127x_dev_s *dev)

Review Comment:
   ```suggestion
   static inline void sx127x_deselect(FAR struct sx127x_dev_s *dev)
   ```



##########
drivers/wireless/nrf24l01.c:
##########
@@ -329,7 +330,7 @@ static inline void nrf24l01_configspi(FAR struct spi_dev_s 
*spi)
  * Name: nrf24l01_select
  ****************************************************************************/
 
-static inline void nrf24l01_select(struct nrf24l01_dev_s * dev)
+static inline void nrf24l01_select(struct nrf24l01_dev_s *dev)

Review Comment:
   ```suggestion
   static inline void nrf24l01_select(FAR struct nrf24l01_dev_s *dev)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org