Gary-Hobson commented on code in PR #7048:
URL: https://github.com/apache/incubator-nuttx/pull/7048#discussion_r982465049


##########
arch/sim/src/Makefile:
##########
@@ -300,7 +300,9 @@ nuttx-names.dat: nuttx-names.in
        $(call PREPROCESS, nuttx-names.in, nuttx-names.dat)
 
 define LINK_ALLSYMS
-       $(Q) $(TOPDIR)/tools/mkallsyms.sh noconst $(NUTTX) $(CROSSDEV) > 
allsyms.tmp
+       $(if $(CONFIG_HOST_MACOS), \
+       $(Q) $(TOPDIR)/tools/mkallsyms.sh noconst $(NUTTX) $(CROSSDEV) > 
allsyms.tmp, \

Review Comment:
   The executable file for Mac is not in elf format, and pyelftools does not 
parse the symbol table correctly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to