[GitHub] [incubator-nuttx] Gary-Hobson commented on a diff in pull request #7048: Optimizing mkallsyms scripts with python

Wed, 28 Sep 2022 06:31:31 -0700 


Gary-Hobson commented on code in PR #7048:
URL: https://github.com/apache/incubator-nuttx/pull/7048#discussion_r982410655


##########
arch/arm/src/Makefile:
##########
@@ -157,7 +157,7 @@ board$(DELIM)libboard$(LIBEXT):
        $(Q) $(MAKE) -C board libboard$(LIBEXT) EXTRAFLAGS="$(EXTRAFLAGS)"
 
 define LINK_ALLSYMS
-       $(Q) $(TOPDIR)/tools/mkallsyms.sh $(NUTTX) $(CROSSDEV) > allsyms.tmp

Review Comment:
   There is a little difference between them, but I don't think it will make 
much difference
   
   [nm.md](https://github.com/apache/incubator-nuttx/files/9665404/nm.md)
   
[pyelftools.md](https://github.com/apache/incubator-nuttx/files/9665405/pyelftools.md)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to