xiaoxiang781216 commented on code in PR #7048:
URL: https://github.com/apache/incubator-nuttx/pull/7048#discussion_r982437745


##########
arch/sim/src/Makefile:
##########
@@ -300,7 +300,9 @@ nuttx-names.dat: nuttx-names.in
        $(call PREPROCESS, nuttx-names.in, nuttx-names.dat)
 
 define LINK_ALLSYMS
-       $(Q) $(TOPDIR)/tools/mkallsyms.sh noconst $(NUTTX) $(CROSSDEV) > 
allsyms.tmp
+       $(if $(CONFIG_HOST_MACOS), \
+       $(Q) $(TOPDIR)/tools/mkallsyms.sh noconst $(NUTTX) $(CROSSDEV) > 
allsyms.tmp, \

Review Comment:
   why not use mkallsyms.py too and remove mkallsyms.sh



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to