gustavonihei commented on code in PR #6603:
URL: https://github.com/apache/incubator-nuttx/pull/6603#discussion_r920031930
##########
arch/xtensa/src/common/xtensa_schedsigaction.c:
##########
@@ -155,6 +156,9 @@ void up_schedule_sigaction(struct tcb_s *tcb, sig_deliver_t
sigdeliver)
(PS_INTLEVEL(XCHAL_EXCM_LEVEL) | PS_UM |
PS_WOE | PS_CALLINC(1));
#endif
+#ifndef CONFIG_BUILD_FLAT
+ mpu_raiseprivilege(CURRENT_REGS);
Review Comment:
> but @patacongo prefer arch specific interface use arm_, riscv_ or xtensa_
prefix, and the common interface shared by all arch use up_ prefix.
I agree, my suggestion was bad, after all, those symbols are only used
within the architecture implementation so they shouldn't be present on the
interface `arch.h`.
> Weak symbol isn't work very well with the static library sometime:
https://stackoverflow.com/questions/13089166/how-to-make-gcc-link-strong-symbol-in-static-library-to-overwrite-weak-symbol
This shouldn't be a problem to NuttX build system, since all the libraries
are passed to the linker within a group (`--start-group`/`--end-group`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
