xiaoxiang781216 commented on code in PR #6603:
URL: https://github.com/apache/incubator-nuttx/pull/6603#discussion_r919596291
##########
arch/xtensa/src/common/xtensa_schedsigaction.c:
##########
@@ -155,6 +156,9 @@ void up_schedule_sigaction(struct tcb_s *tcb, sig_deliver_t
sigdeliver)
(PS_INTLEVEL(XCHAL_EXCM_LEVEL) | PS_UM |
PS_WOE | PS_CALLINC(1));
#endif
+#ifndef CONFIG_BUILD_FLAT
+ mpu_raiseprivilege(CURRENT_REGS);
Review Comment:
> > low/raise cpu/dsp priority is normally done by core self
>
> How about prefixing it with `up_` and declaring it on
`include/nuttx/arch.h`?
but @patacongo prefer arch specific interface use arm_, riscv_ or xtensa_
prefix, and the common interface shared by all arch use up_ prefix.
> Then, at architectural level, there could exist weak implementation of
those functions which, if needed, could be overriden by chip-specific ones (the
case for Espressif chips).
Weak symbol isn't work very well with the static library sometime:
https://stackoverflow.com/questions/13089166/how-to-make-gcc-link-strong-symbol-in-static-library-to-overwrite-weak-symbol
> The RISC-V implementation manipulates the `STATUS_PPP` flag and could also
benefit from this abstraction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
