pkarashchenko commented on code in PR #6435: URL: https://github.com/apache/incubator-nuttx/pull/6435#discussion_r897942152
########## drivers/syslog/syslog_device.c: ########## @@ -83,8 +79,7 @@ struct syslog_dev_s uint8_t sl_state; /* See enum syslog_dev_state */ uint8_t sl_oflags; /* Saved open mode (for re-open) */ uint16_t sl_mode; /* Saved open flags (for re-open) */ - sem_t sl_sem; /* Enforces mutually exclusive access */ - pid_t sl_holder; /* PID of the thread that holds the semaphore */ + rmutex_t sl_lock; /* Enforces mutually exclusive access */ Review Comment: I mean that current implementation of `nxmutex_` is lacking of `holder` information and allows releasing from the task that didn't acquired the mutex and here recursive mutex used only because it has the `holder` field, but `sl_lock` does not have recursive nature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
