[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

[GitBox]

xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r835755890



##########
File path: arch/risc-v/include/syscall.h
##########
@@ -391,6 +396,64 @@ static inline uintptr_t sys_call6(unsigned int nbr, 
uintptr_t parm1,
   return r0;
 }
 
+#ifdef CONFIG_ARCH_USE_S_MODE
+
+/* In S-mode the kernel cannot ecall to itself, because ecall will raise
+ * privileges to M-mode, which is not what we want. Instead, use the syscall
+ * trampoline to do the same.
+ */
+
+static inline uintptr_t ksys_call3(unsigned int nbr, uintptr_t parm1,

Review comment:
       @pussuw after more thinking, it's more better to merge ksys_callx into 
sys_callx like this:
   ```
   static inline uintptr_t sys_call?(unsigned int nbr, ...)
   {
     register long r0 asm("a0") = (long)(nbr);
     ...
   #ifdef CONFIG_ARCH_USE_S_MODE
   ...
   #else
      ...
   #endif
     return r0;
   }
   ```
   So, we don't need modify other place.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org