gustavonihei commented on a change in pull request #929:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/929#discussion_r772647930
##########
File path: examples/mcuboot/ota/Kconfig
##########
@@ -0,0 +1,56 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig EXAMPLES_MCUBOOT_OTA
Review comment:
We're not talking about the same issues here.
Regarding the code move, I am already okay with that, as I stated in my last
comment. Also with the addition of `EXAMPLES_` to the Kconfig config names,
which is related to the code move.
So, the previous `MCUBOOT_UPDATE_AGENT_EXAMPLE` key, once moved, should
simply become `EXAMPLES_MCUBOOT_UPDATE_AGENT`. And that's it. That achieves the
purpose of this PR.
That's why I said to restrict the PR to these changes only, to avoid
hindering the merge.
I am not okay with everything else in this PR, because those other changes
lack background.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
