gustavonihei commented on a change in pull request #929:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/929#discussion_r772609676
##########
File path: examples/mcuboot/ota/Kconfig
##########
@@ -0,0 +1,56 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig EXAMPLES_MCUBOOT_OTA
Review comment:
> The simple fact that this refactor is necessary
If this is indeed necessary, the motivation for this refactor should be
stated on the PR description. So far, I still consider these changes
superfluous. The changes to the names and help text of Kconfig options, in my
opinion, bring no improvement over the previous version.
> This helps to improve into a more generic and easy to use way. Since it is
required replace strings in the main NuttX repo, it is better perform once with
right value, instead twice.
How does these changes in this PR cope with it?
> Maybe EXAMPLES_MCUBOOT_UPDATE is a more consistent prefix name and
_AGENT/_CONFIRM better suffixes.
The prefix is just `EXAMPLES_MCUBOOT_`. I don't understand how this notion
of suffix fits here. There is no suffix in the Kconfig names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
