nandojve commented on a change in pull request #929:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/929#discussion_r772637956
##########
File path: examples/mcuboot/ota/Kconfig
##########
@@ -0,0 +1,56 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig EXAMPLES_MCUBOOT_OTA
Review comment:
> If this is indeed necessary, the motivation for this refactor should
be stated on the PR description. So far, I still consider these changes
superfluous. The changes to the names and help text of Kconfig options, in my
opinion, bring no improvement over the previous version.
_The current version of MCUboot have core and [define] example[s] together.
This moves samples to apps/examples directory to clean up._ This is a clear
motivation. The Kconfig name changes are necessary to keep name convention
consistent once in all examples the Kconfig variables starts with EXAMPLES_.
> How does these changes in this PR cope with it?
The cleaning up require Kconfig name changes to keep consistency. This
should be reflected into boards/configs/defconfig, which are related to
MCUboot. README files may be affected because can describe how build/flash for
users, for instance.
> The prefix is just EXAMPLES_MCUBOOT_. I don't understand how this notion
of suffix fits here. There is no suffix in the Kconfig names.
The prefix is just the constant part of Kconfig symbol, which repeat in the
whole Kconfig file example, nothing more. The suffix is the remaining part.
This PR moves MCUboot _samples_ to _a new application example_ inside
examples/mcuboot/ota. For this initial proposal, prefix should be
EXAMPLES_MCUBOOT_OTA. If this name is not OK I would like to change it. What do
you suggest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
