acassis commented on pull request #3487:
URL: https://github.com/apache/incubator-nuttx/pull/3487#issuecomment-816869553


   > Hi Alan,
   > 
   > Yes, I'm familiar with git. It's my daily business. But when a quashed 
single commit is expected git rebase is not the solution. Furthermore, I have 
no permission to create branches on apache-nuttx but only pull requests from my 
github account. So I have to make a new pull request, I think, or a forced push 
that is more or less the same in this context.
   > 
   > What I have to do now?
   > A pull request with a long-running commit history and adding changes on 
top? A single squashed commit? What about the new driver I'm working on and the 
expected board example? Should it be a commit on top or an extra pull request 
on what?
   > Personally, I'm not happy with single squashed commits but I'm willing to 
help out to make the review process as easy as possible.
   
   @Marco-Krahl we can use your branch, squash it and git force, the github 
will update your PR automatically.
   
   Normally I follow these steps: 
https://acassis.wordpress.com/2021/03/29/how-i-submit-pull-request-to-nuttx/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to