[GitHub] [incubator-nuttx] Marco-Krahl commented on a change in pull request #3487: Adds common master bus interface and implementation for onewire support

[GitBox]

Marco-Krahl commented on a change in pull request #3487:
URL: https://github.com/apache/incubator-nuttx/pull/3487#discussion_r612682876



##########
File path: drivers/1wire/1wire.c
##########
@@ -554,6 +562,7 @@ int onewire_search(FAR struct onewire_master_s *master,
           nslaves_match++;
         }
 
+      onewire_sem_post(master);
       return (ret < 0) ? ret : nslaves_match;

Review comment:
       I will rename err_unlock to unlock because the case in line 565 isn't 
explicit an error.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org