Marco-Krahl commented on a change in pull request #3487:
URL: https://github.com/apache/incubator-nuttx/pull/3487#discussion_r610738637



##########
File path: drivers/1wire/ds28e17.c
##########
@@ -45,6 +45,7 @@
 
 #include <nuttx/kmalloc.h>
 #include <nuttx/i2c/i2c_master.h>

Review comment:
       kmalloc include can be remove here but not i2c_master. This existing 
driver is a 1wire to i2c bridge. So both interfaces are necessary.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to