Ouss4 commented on a change in pull request #3003:
URL: https://github.com/apache/incubator-nuttx/pull/3003#discussion_r591150127
##########
File path: arch/xtensa/src/esp32/esp32_allocateheap.c
##########
@@ -96,8 +96,15 @@ void xtensa_add_region(void)
{
size_t region2_start = HEAP_REGION2_START + XTENSA_IMEM_REGION_SIZE;
+#ifndef CONFIG_SMP
umm_addregion((FAR void *)region2_start,
(size_t)(uintptr_t)&_eheap - region2_start);
+#else
+ umm_addregion((FAR void *)region2_start,
+ (size_t)HEAP_REGION2_END - region2_start);
+ umm_addregion((FAR void *)HEAP_REGION3_START,
+ (size_t)&_eheap - HEAP_REGION3_START);
Review comment:
I was going to edit the commit, but I remembered that it was part of it
in the first place.
> my suggestion is do nothing.
I'll take your suggestion. ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
