Ouss4 commented on a change in pull request #3003:
URL: https://github.com/apache/incubator-nuttx/pull/3003#discussion_r590022179
##########
File path: arch/xtensa/include/esp32/memory_layout.h
##########
@@ -80,18 +83,16 @@
#endif
#ifdef CONFIG_XTENSA_IMEM_USE_SEPARATE_HEAP
-#define XTENSA_IMEM_REGION_SIZE CONFIG_XTENSA_IMEM_REGION_SIZE
+# define XTENSA_IMEM_REGION_SIZE CONFIG_XTENSA_IMEM_REGION_SIZE
#else
-#define XTENSA_IMEM_REGION_SIZE 0
+# define XTENSA_IMEM_REGION_SIZE 0
#endif
-/* If CONFIG_XTENSA_IMEM_MAXIMIZE_HEAP_REGION is defined, it means
- * using maximum separate heap for internal memory, but part of
- * the available memory is reserved for the Region 1 heap.
- */
+/* Internal heap starts at the end of the ROM data. */
-#ifdef CONFIG_XTENSA_IMEM_MAXIMIZE_HEAP_REGION
-#ifndef HEAP_REGION_OFFSET
-#define HEAP_REGION_OFFSET 0x2000
-#endif
+#ifndef CONFIG_SMP
+# define ESP32_IMEM_START 0x3ffe1330
Review comment:
It's not always the start of region2, in SMP it's the start of region3.
I can change it to:
```C
#ifndef CONFIG_SMP
# define ESP32_IMEM_START HEAP_REGION2_START
#else
# define ESP32_IMEM_START HEAP_REGION3_START
#endif
```
Which I think is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
