michallenc commented on pull request #2929:
URL: https://github.com/apache/incubator-nuttx/pull/2929#issuecomment-786580422


   > @michallenc - Please check the order of of operation in the 
`imxrt_caninitialize` path. `imxrt_ifdown` is called on the interface with out 
an initialize. The SOFT RESET will fail as the clock is not running and return 
here, 
https://github.com/michallenc/incubator-nuttx/blob/4b65e3647124e935264725d014310a3e9ae4a7cf/arch/arm/src/imxrt/imxrt_flexcan.c#L1746
   > 
   > Adding imxrt_initialize(priv) here 
https://github.com/michallenc/incubator-nuttx/blob/4b65e3647124e935264725d014310a3e9ae4a7cf/arch/arm/src/imxrt/imxrt_flexcan.c#L1941
   > 
   > will fix it
   
   That´s weird. What configuration are you running? I don´t seem to be getting 
the same problem:
   `nsh> imxrt_caninitialize: callbacks done
   imxrt_reset: MB 0 0x401d0080
   imxrt_reset: MB 0 0x401d0084
   imxrt_reset: MB 1 0x401d0090
   imxrt_reset: MB 1 0x401d0094
   imxrt_reset: MB 2 0x401d00a0
   imxrt_reset: MB 2 0x401d00a4
   imxrt_reset: MB 3 0x401d00b0
   imxrt_reset: MB 3 0x401d00b4
   imxrt_reset: MB 4 0x401d00c0
   imxrt_reset: MB 4 0x401d00c4
   imxrt_reset: MB 5 0x401d00d0
   imxrt_reset: MB 5 0x401d00d4
   imxrt_reset: MB 6 0x401d00e0
   imxrt_reset: MB 6 0x401d00e4
   imxrt_reset: MB 7 0x401d00f0
   imxrt_reset: MB 7 0x401d00f4
   imxrt_reset: MB 8 0x401d0100
   imxrt_reset: MB 8 0x401d0104
   imxrt_reset: MB 9 0x401d0110
   imxrt_reset: MB 9 0x401d0114
   imxrt_reset: MB 10 0x401d0120
   imxrt_reset: MB 10 0x401d0124
   imxrt_reset: MB 11 0x401d0130
   imxrt_reset: MB 11 0x401d0134
   imxrt_reset: MB 12 0x401d0140
   imxrt_reset: MB 12 0x401d0144
   imxrt_reset: MB 13 0x401d0150
   imxrt_reset: MB 13 0x401d0154
   netdev_register: Registered dev: can0
   `
   I can´t test the fix as the problem for some reason doesn´t occur in my 
board, but if you can fix it and test it then please make the PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to