xiaoxiang781216 commented on a change in pull request #594:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/594#discussion_r578922743
##########
File path: netutils/ntpclient/ntpclient.c
##########
@@ -625,14 +699,15 @@ static void ntpc_settime(int64_t offset, FAR struct
timespec *start_realtime,
*
****************************************************************************/
-static bool ntp_address_in_kod_list(FAR const union ntp_addr_u *server_addr)
+static bool ntp_address_in_kod_list(FAR const struct sockaddr *server_addr)
Review comment:
socket API stick to sockaddr, because they need to keep the
compatibility, but we don't have this restriction for internal NTP client
function. So if the caller declares variables as ntp_addr_u, why we change
other function prototype from ntp_addr_u to sockaddr and spread the cast around
the code base?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
