yamt commented on a change in pull request #594: URL: https://github.com/apache/incubator-nuttx-apps/pull/594#discussion_r578913501
########## File path: netutils/ntpclient/ntpclient.c ########## @@ -625,14 +699,15 @@ static void ntpc_settime(int64_t offset, FAR struct timespec *start_realtime, * ****************************************************************************/ -static bool ntp_address_in_kod_list(FAR const union ntp_addr_u *server_addr) +static bool ntp_address_in_kod_list(FAR const struct sockaddr *server_addr) Review comment: do you mean, you prefer to use ntp_addr_u all over places, including sockaddr_cmp and sockaddr_len? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org