xiaoxiang781216 commented on a change in pull request #594:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/594#discussion_r577420843
##########
File path: netutils/ntpclient/ntpclient.c
##########
@@ -625,14 +699,15 @@ static void ntpc_settime(int64_t offset, FAR struct
timespec *start_realtime,
*
****************************************************************************/
-static bool ntp_address_in_kod_list(FAR const union ntp_addr_u *server_addr)
+static bool ntp_address_in_kod_list(FAR const struct sockaddr *server_addr)
Review comment:
Why sockaddr_storage awkward here?
NTP client support both ipv4 and ipv6, so sockaddr_storage is the better
representation to this fact. sockaddr can only express ipv4 address which isn't
good enough to express this case.
Yes, there are many socket api(e.g. bind, connect) have to use sockaddr even
they support many address family for the compatiblity reason. But, we don't
have this restriction for the internal interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
