xiaoxiang781216 commented on code in PR #19116: URL: https://github.com/apache/nuttx/pull/19116#discussion_r3408546393
########## sched/signal/sig_initialize.c: ########## @@ -190,6 +194,7 @@ void nxsig_initialize(void) sq_init(&g_sigpendingsignal); sq_init(&g_sigpendingirqsignal); +#ifdef CONFIG_ENABLE_ALL_SIGNALS Review Comment: remove line 189-195 ########## sched/signal/sig_dispatch.c: ########## @@ -279,6 +280,7 @@ nxsig_find_pendingsignal(FAR struct task_group_s *group, int signo) * Name: nxsig_dispatch_kernel_action ****************************************************************************/ +#ifdef CONFIG_ENABLE_ALL_SIGNALS static void nxsig_dispatch_kernel_action(FAR struct tcb_s *stcb, Review Comment: move before line 206 and remove line 283/297 ########## syscall/syscall.csv: ########## @@ -56,7 +56,7 @@ "inotify_rm_watch","sys/inotify.h","defined(CONFIG_FS_NOTIFY)","int","int","int" "insmod","nuttx/module.h","defined(CONFIG_MODULE)","FAR void *","FAR const char *","FAR const char *" "ioctl","sys/ioctl.h","","int","int","int","...","unsigned long" -"kill","signal.h","","int","pid_t","int" +"kill","signal.h","!defined(CONFIG_DISABLE_ALL_SIGNALS)","int","pid_t","int" Review Comment: revert ########## sched/signal/sig_initialize.c: ########## @@ -53,7 +55,7 @@ struct sigpool_s /* This is a pool of pre-allocated signal action structures buffers */ -#if CONFIG_SIG_PREALLOC_ACTIONS > 0 +#if defined(CONFIG_ENABLE_ALL_SIGNALS) && CONFIG_SIG_PREALLOC_ACTIONS > 0 sigactq_t g_sigactions[CONFIG_SIG_PREALLOC_ACTIONS]; #endif Review Comment: move `#endif` after line 79 ########## sched/signal/sig_dispatch.c: ########## @@ -727,14 +733,14 @@ int nxsig_tcbdispatch(FAR struct tcb_s *stcb, siginfo_t *info, leave_critical_section(flags); -#ifdef CONFIG_ENABLE_ALL_SIGNALS Review Comment: why change ########## sched/signal/signal.h: ########## @@ -166,7 +166,7 @@ struct task_group_s; /* sig_initializee.c */ -#ifdef CONFIG_ENABLE_ALL_SIGNALS +#ifndef CONFIG_DISABLE_ALL_SIGNALS Review Comment: remove the check directly since most function declaration in this file isn't guarded by Kconfig ########## sched/signal/signal.h: ########## @@ -194,7 +194,7 @@ int nxsig_dispatch(pid_t pid, FAR siginfo_t *info, /* sig_cleanup.c */ -#ifdef CONFIG_ENABLE_ALL_SIGNALS +#ifndef CONFIG_DISABLE_ALL_SIGNALS Review Comment: ditto ########## include/sys/syscall_lookup.h: ########## @@ -152,8 +152,10 @@ SYSCALL_LOOKUP(nxsem_wait_slow, 1) * configuration. */ +#ifndef CONFIG_DISABLE_ALL_SIGNALS Review Comment: revert -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
