jlaitine commented on code in PR #19116:
URL: https://github.com/apache/nuttx/pull/19116#discussion_r3407995356
##########
libs/libc/pthread/pthread_mutex_consistent.c:
##########
@@ -103,6 +103,7 @@ int pthread_mutex_consistent(FAR pthread_mutex_t *mutex)
* nxsched_get_tcb() does.
*/
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
if (pthread_kill(pid, 0) != 0)
Review Comment:
I re-enabled the pthread_kill on CONFIG_DISABLE_ALL_SIGNALS, and then added
also similar stub for the same for "kill" into libc. After which I realized
that there is no reason(?) to have both kill and tgkill in the syscall
interface, so I made another cleanup patch to move the kill entirely into libc,
implementing it with tgkill.
I did testing with ostest on armv8a. I wasn't sure how to squash the
commits, so I just left the history in working order, I think it is not too
confusing after all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
