xiaoxiang781216 commented on code in PR #19116:
URL: https://github.com/apache/nuttx/pull/19116#discussion_r3394605864


##########
sched/signal/sig_suspend.c:
##########
@@ -108,6 +108,7 @@ int sigsuspend(FAR const sigset_t *set)
    * signals that will be unblocked by the new sigprocmask.
    */
 
+#ifdef CONFIG_ENABLE_ALL_SIGNALS
   if (nxsig_unmask_pendingsignal())

Review Comment:
   partial enable should still support sigprocmask, here is the difference:
   
   1. enable all: support both signal callback and signal wakup(e..g sigwait)
   2. partial enable: only support signal wakup
   3. disable all: all signal function is removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to