xiaoxiang781216 commented on PR #17352: URL: https://github.com/apache/nuttx/pull/17352#issuecomment-3570812860
> 2. You have made numerous kernel modifications, yet no one is willing to submit them to the community. Every time @wangchdo contributes valuable code, you instruct individuals from Xiaomi to submit code with identical functionality. Similar issues exist with the hwtimer [sched/hrtimer: add a high resolution timer module in sched and tricore porting to support hard real time cases #17065](https://github.com/apache/nuttx/pull/17065) I already point out the key problem of https://github.com/apache/nuttx/pull/17065, which must be fixed before I can approve it. do you mean @Fix-Point 's pr: https://github.com/apache/nuttx/pull/17312, https://github.com/apache/nuttx/pull/17316, https://github.com/apache/nuttx/pull/17339 and https://github.com/apache/nuttx/pull/17338? which is totally different from https://github.com/apache/nuttx/pull/17065. > and current PR. Do you review https://github.com/apache/nuttx/pull/17352 and https://github.com/apache/nuttx/pull/17357 carefully? The detail is totally different as I already mention many time, so I don't repeat the difference here again. Both approach has the pron. and cron., so I suggest to accept both by disabling the signal by level. > Why do you consistently challenge individual developers' submissions instead of assisting them in merging their work into the community? This is unfair—not just to individual developers, but to the entire developer community. I review @wangchdo 's patch carefully and point out the place which need improve, once the problem get fixed, I always approve and his change. could you point out which patch I block it after the comment get addressed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
